Fix QR code popup - #355
Closed
Sajgon27 wants to merge 4 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the checkout complete page the QR code popup wasn't showing at all — a guard added during the Sylius 1 → 2 migration bailed out early when the select-payment container was missing, so the popup never ran there. Once that was fixed the popup showed briefly but then redirected to an error page, because the order had no orderToken yet during checkout, so the redirect went to /thank-you?orderToken=null → "Order with token null does not exist".
Fix: run the popup on the complete page regardless of the guard, and assign the order token when the QR payment is created so the flow has a valid token to poll and redirect with.